Dry-transaction: Better error for a missing step

fenec · October 12, 2017, 4:33pm

If I don’t describe a step, I get: NameError: undefined method call for class NilClass

because method(:call) in #arity is called on nil:

dry-rb/dry-transaction/blob/v0.10.2/lib/dry/transaction/step.rb#L59


      result.fmap { |value|
        broadcast :"#{step_name}_success", value
        value
      }.or { |value|
        broadcast :"#{step_name}_failure", *args, value
        Left(StepFailure.new(self, value))
      }
    end


    def arity
      operation.is_a?(Proc) ? operation.arity : operation.method(:call).arity
    end
  end
end
end

I think, would be better to raise a more descriptive error in this case.

GustavoCaso · October 13, 2017, 1:04pm

@fenec what do you mean when you do “not describe a step”.

Is missing from the container or no method is defined in the class?

fenec · October 14, 2017, 4:51am

method is not defined in the class

Topic		Replies	Views
Expose dry-transaction failure step names Ideas	0	748	October 26, 2018
Difficulty setting up around-step with dry-transaction Support	10	819	February 23, 2023
Nested transactions with step arguments buggy? Support	2	728	May 3, 2019
[Dry::Transaction] How I can add steps which will be called on fail and on any cases?	7	2356	November 22, 2017
Dry-transaction: allow injecting operations for steps defined as methods? Ideas	8	2900	March 22, 2018

Dry-transaction: Better error for a missing step

Related Topics